Skip to content

Fixing tests #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing tests #361

wants to merge 2 commits into from

Conversation

@NylePudding
Copy link

@NylePudding NylePudding commented Jun 26, 2021 •
edited
Loading

fixes #358

Spent some time going through the tests and making sure they worked properly.

Some key points:

  • I updated Mocha (9.0.1) and Spectron (6.0.0) so WebDriverIO could be updated to 4.14.4.
  • Unfortunately due to a bug in WebDriverIO v4 elements can't be cleared, so I cleared ace_text-input by simulating the delete key 126 times. I also couldn't find a way to read the length of the text in ace_text-input hence the magic number.
  • Now these are fixed I would be happy to write more tests! :)

SpoonMeiser
SpoonMeiser reviewed Oct 5, 2021
View reviewed changes
@NylePudding
Copy link
Author

Apologies, but I haven't done a huge amount of GitHub collaboration and I'm not sure how to progress this and get it merged. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SpoonMeiser SpoonMeiser SpoonMeiser left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests are failing

2 participants

@NylePudding @SpoonMeiser