fix: use with_chain, improve logging
#22
Merged
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anna-carroll
commented
Oct 23, 2025
anna-carroll
commented
- MUST call with_chain before signing orders
- clarify misleading log message
- add log for RU transaction hashes to improve observability
anna-carroll
changed the title
with_chain, improve logging
Evalir
reviewed
Oct 23, 2025
Comment on lines
+106
to
+109
| let signed = order | ||
| .with_chain(config.constants.system()) | ||
| .sign(signer) | ||
| .await?; |
There was a problem hiding this comment.
i'm a bit confused about this. if there's no chain id set, shouldn't signing the order outright fail? how was this working before?
There was a problem hiding this comment.
it wasn't working. it got broken when SDK got updated to a later version, maybe #19? the code compiled without it but was running the script tested?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.