fix: use arg line instead of arg value for yaz.cflags in swig exec#14
Merged
Merged
Conversation
The Windows profile is just as broken ( Lines 376 and 386), but the fix is irrelevant there (unless there is a space in the path).
Contributor
Author
|
Also it might be the fix to the only open issue: centos 7 build failed,jdk 8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the generate-sources antrun execution, yaz.cflags is passed to swig via <arg value>,
which treats the entire pkg-config --cflags yaz output as a single opaque argument.
On any system where pkg-config returns multiple tokens (e.g. -I/... -DYAZ_POSIX_THREADS=1 -DYAZ_HAVE_XML2=1 ...), swig never receives the -I flag and exits with:
Fix
Change <arg value="${yaz.cflags}"> to <arg line="${yaz.cflags}"> in the swig exec block.
<arg line> splits the value on whitespace and passes each token as a separate argument, which is the correct behaviour for compiler flag strings.
Note
The Windows profile is just as broken ( Lines 376 and 386), but the fix is irrelevant there (unless there is a space in the path).