Skip to content

Update QuantumLib to Coq 8.20#50

Merged
adrianleh merged 6 commits intomainfrom
coq-8-20
Jul 16, 2025
Merged

Update QuantumLib to Coq 8.20#50
adrianleh merged 6 commits intomainfrom
coq-8-20

Conversation

@wjbs
Copy link
Copy Markdown
Collaborator

@wjbs wjbs commented Jul 16, 2025

I fixed the few conflicts I found with the update, and I believe the fixes should be backwards-compatible (hopefully CI agrees).

There are still a large number of deprecation warnings, some new to 8.20 but many from 8.17 that could be resolved if we want to drop support for that version.

@wjbs wjbs requested a review from adrianleh July 16, 2025 01:44
@adrianleh
Copy link
Copy Markdown
Member

Can you change the CI config to include 8.20?

@adrianleh
Copy link
Copy Markdown
Member

dune-project has some offending lines that prevent 8.20 from working:

 (depends
   (coq (and (>= 8.16) (< 8.20)))))

Copy link
Copy Markdown
Member

@adrianleh adrianleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with 8.20.

@adrianleh adrianleh merged commit 0a6d68e into main Jul 16, 2025
5 checks passed
@adrianleh adrianleh deleted the coq-8-20 branch July 16, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants