-
Notifications
You must be signed in to change notification settings - Fork 0
Create overlay component #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dmontesi
commented
Jan 7, 2026
- New overlay component
✅ Deploy Preview for imarc-pronto ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a new “overlay” molecule built on the native <dialog> element, and introduces a dialog molecule stylesheet/demo while updating SCSS forwards.
Changes:
- Added overlay HTML demos and SCSS for a full-screen dialog-based overlay.
- Added a dialog molecule (SCSS + HTML demo) and forwarded it via
molecules/index.scss. - Removed the
dialogforward fromorganisms/index.scssand added forwards fordialogandoverlayunder molecules.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/styles/organisms/index.scss | Removes forwarding of dialog from organisms. |
| resources/styles/molecules/index.scss | Forwards new dialog and overlay molecule styles. |
| resources/styles/molecules/overlay/index.scss | Implements overlay styling (full-screen dialog + backdrop behavior). |
| resources/styles/molecules/overlay/overlay.html | Adds a closed-state overlay demo with an open trigger. |
| resources/styles/molecules/overlay/overlay--opened.html | Adds an opened-state overlay demo (static open attribute + simulated backdrop). |
| resources/styles/molecules/dialog/index.scss | Adds dialog styling and close-button positioning rules. |
| resources/styles/molecules/dialog/dialog.html | Adds a dialog markup demo with a close button. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <button class="button" onclick="document.querySelector('.overlay').showModal()">Open Overlay</button> | ||
| </div> |
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These HTML component demos appear to avoid inline event handlers (e.g., resources/styles/molecules/accordion/accordion.html:1-30 and resources/styles/molecules/mobileNavigation/mobileNavigation.html:22-25 use markup/framework bindings, not onclick). Using inline onclick here makes the snippet inconsistent and harder to reuse in templated contexts. Consider switching to the project’s usual event binding approach (e.g., framework @click) or documenting the required JS separately.
|
Is the idea for overlay--opened.html to be an example of something like intro/splash? My main feedback on that part is I think I'd rather see that be implemented as a modifier, like These two use cases might be separate enough to even merit two different components rather than the sibling |