fix: Clip only the enabled FlClipData sides in line chart#2107
Open
martin-dehlan wants to merge 1 commit into
Open
fix: Clip only the enabled FlClipData sides in line chart#2107martin-dehlan wants to merge 1 commit into
martin-dehlan wants to merge 1 commit into
Conversation
clipToBorder built a single rect and passed it to clipRect, which clips all four sides. Disabled sides were left at the canvas edge, so they still clipped overflow. Enabling any single side therefore clipped all four sides. Disabled sides now extend to infinity so clipRect leaves them unbounded; only the sides enabled in FlClipData get a real boundary. Fixes imaNNeo#1262 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
4 tasks
martin-dehlan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LineChart'sclipToBorder()built a single rect and passed it toclipRect, which always clips all four sides. Disabled sides were left at the canvas edge, so they still clipped overflow. As a result, enabling any single side inFlClipDataclipped all four sides.Disabled sides now extend to infinity, leaving them unbounded in
clipRect; only the sides explicitly enabled inFlClipDataget a real boundary. (Canvas.clipRectaccepts infinite rects — its validity check only rejectsNaN.)Checklist
///.example.Breaking Change?
Related Issues
Closes #1262