feat!: Add support for unified customization of path pattern#2106
Open
nikodembernat wants to merge 6 commits into
Open
feat!: Add support for unified customization of path pattern#2106nikodembernat wants to merge 6 commits into
nikodembernat wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a unified way of customizing various lines (bar chart border, line chart dashes, etc.).
Checklist
///.example.Breaking Change?
Migration instructions
I tried balancing required changes and backwards-compatibility, so all existing fields in the constructors should continue to work, but are marked as deprecated. It results in some more complex logic inside
FlLinesince it's the only one that uses aconstconstructor, but I added an assertion to make sure people don't make partial migrations.As for examples of migration, it's quite straightforward:
tldr: everything uses the following class
Additional notes
FlDashData, but then I realized that it's not always used in the context of dashes (e.g.LineChartBarData->strokeCap), so I renamed it toFlPathData.data_pool.dart, it should clarify some stuff).