Make status command find migrations in subdirectories#367
Merged
vprigent merged 1 commit intoilyakatz:mainfrom Nov 7, 2025
Merged
Make status command find migrations in subdirectories#367vprigent merged 1 commit intoilyakatz:mainfrom
status command find migrations in subdirectories#367vprigent merged 1 commit intoilyakatz:mainfrom
Conversation
Previously, `db:migrate:status:with_data` used `Dir.foreach` and
`Dir.children`, which only scan the top-level migration directory. As a
result, archived migrations placed in subdirectories (e.g.,
`db/migrate/archive/`) appeared as "*** NO SCHEMA FILE ***" even though
they existed in the database.
The fix switches to `Dir.glob` with a recursive `**/*.rb` pattern and
then filters by matching file basenames against `/(\d{14})_(.+)\\.rb/`,
enabling the command to find migrations in nested directories and
correctly report their status.
This ensures that migrations stored anywhere under the migration paths
are recognized and displayed accurately in the status output.
Before:
```
~/Project (main) % bundle exec rake db:migrate:status | grep 20210323133030
up 20210323133030 Create resource
~/Project (main) % bundle exec rake db:migrate:status:with_data | grep 20210323133030
up 20210323133030 *** NO SCHEMA FILE ***```
```
After:
```
~/Project (main) % bundle exec rake db:migrate:status | grep 20210323133030
up 20210323133030 Create resource
~/Project (main|!|+) % bundle exec rake db:migrate:status:with_data | grep 20210323133030
up schema 20210323133030 Create resource
```
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
db:migrate:status:with_datausedDir.foreachandDir.children, which only scan the top-level migration directory. As a result, archived migrations placed in subdirectories (e.g.,db/migrate/archive/) appeared as "*** NO SCHEMA FILE ***" even though they existed in the database.The fix switches to
Dir.globwith a recursive**/*.rbpattern and then filters by matching file basenames against/(\d{14})_(.+)\\.rb/, enabling the command to find migrations in nested directories and correctly report their status.This ensures that migrations stored anywhere under the migration paths are recognized and displayed accurately in the status output.
Before:
After: