Schema version -- do formatted version like activerecord#363
Merged
vprigent merged 3 commits intoilyakatz:mainfrom Apr 17, 2025
Merged
Schema version -- do formatted version like activerecord#363vprigent merged 3 commits intoilyakatz:mainfrom
vprigent merged 3 commits intoilyakatz:mainfrom
Conversation
Contributor
Author
|
@ilyakatz just a heads up for a relatively small QoL PR. |
Collaborator
|
Hey, thanks for the contribution! It feels a bit like one of those bikeshed-friendly things, BUT! That brings consistency with ActiveRecord and modern Rails, so I'm all for it I'll merge it a bit later, unless someone can say objective reasons why not |
Collaborator
|
Meanwhile, could you please update this test to match? |
vprigent
reviewed
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in a formatted version number to the schema record similar to how it is done in activerecord which leads to easier to read conflict resolutions.
E.g. converting
into
just like an activerecord schema looks: