Skip to content

Schema version -- do formatted version like activerecord#363

Merged
vprigent merged 3 commits intoilyakatz:mainfrom
mcyoung:mcy/feature/format-version
Apr 17, 2025
Merged

Schema version -- do formatted version like activerecord#363
vprigent merged 3 commits intoilyakatz:mainfrom
mcyoung:mcy/feature/format-version

Conversation

@mcyoung
Copy link
Contributor

@mcyoung mcyoung commented Apr 17, 2025

Adds in a formatted version number to the schema record similar to how it is done in activerecord which leads to easier to read conflict resolutions.

E.g. converting

DataMigrate::Data.define(version: 20250415225942)

into

DataMigrate::Data.define(version: 2025_04_15_225942)

just like an activerecord schema looks:

ActiveRecord::Schema[7.2].define(version: 2025_04_16_223838) do

@mcyoung mcyoung changed the title Do formatted version like activerecord Schema version -- do formatted version like activerecord Apr 17, 2025
@mcyoung
Copy link
Contributor Author

mcyoung commented Apr 17, 2025

@ilyakatz just a heads up for a relatively small QoL PR.

@Morozzzko
Copy link
Collaborator

Hey, thanks for the contribution!

It feels a bit like one of those bikeshed-friendly things, BUT! That brings consistency with ActiveRecord and modern Rails, so I'm all for it

I'll merge it a bit later, unless someone can say objective reasons why not

@Morozzzko
Copy link
Collaborator

Meanwhile, could you please update this test to match?

@vprigent vprigent merged commit d4cebfa into ilyakatz:main Apr 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants