Be able to force synchronization when copying graph inputs#2092
Open
ikawrakow wants to merge 1 commit into
Open
Be able to force synchronization when copying graph inputs#2092ikawrakow wants to merge 1 commit into
ikawrakow wants to merge 1 commit into
Conversation
ikawrakow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2083
#2083 reports corrupted results for GLM-5.2 when using
-ngl NwithNless than the number of model layers. This PR adds the ability to turn off the synchronization elision optimization when copying graph split inputs from other device(s) at compile time by addingto the
cmakecommand.