Qwen3.5 MTP: extract selected tokens earlier#1892
Open
ikawrakow wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When accepting tokens with the draft model, instead of 1st computing the entire attention and then extracting the requested token(s) (which is basically always just the last token), pass the requested output ids to the
build_std_attentionfunction, which has the functionality built in. This reduces the cost of the multiplication with the attention output tensor.It is a very minor optimization, so the main motivation was to make the MTP graph more standard.
I do see 1-2% TG performance improvement for Qwen3.5-9B. For the larger models it is within the noise.