fix(gio.desktopapp): replace deprecated gio.desktopapp by giounix.desktopapp#438
Open
tr1xem wants to merge 2 commits intoignis-sh:mainfrom
Open
fix(gio.desktopapp): replace deprecated gio.desktopapp by giounix.desktopapp#438tr1xem wants to merge 2 commits intoignis-sh:mainfrom
tr1xem wants to merge 2 commits intoignis-sh:mainfrom
Conversation
Member
|
There an issue with Gio < 2.86, see https://gitlab.gnome.org/GNOME/pygobject/-/issues/719 |
Contributor
Author
|
@linkfrg by the look of it they fixed it i guess |
Member
|
Hmm, I think we should add a check for PyGObject versions without this fix: < 3.52.4; 3.54.5; 3.50.2; and use the old Gio API for them. |
Contributor
Author
|
@linkfrg I think everyone now have latest gobject version nix pkg have 3.54.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #437
Tested on my machine