feat(HyprlandService): support urgent event#428
feat(HyprlandService): support urgent event#428PacificViking wants to merge 13 commits intoignis-sh:mainfrom
urgent event#428Conversation
ignis/services/hyprland/service.py
Outdated
| def urgent_windows(self) -> list[str]: | ||
| """ | ||
| - read-only | ||
|
|
||
| A list of urgent windows. | ||
| """ | ||
| return list(self._urgent_windows) | ||
|
|
||
| @IgnisProperty | ||
| def urgent_workspaces(self) -> list[str]: |
There was a problem hiding this comment.
They should return a list of HyprlandWindow and HyprlandWorkspace accordingly
There was a problem hiding this comment.
This should be done in my latest commits.
ignis/services/hyprland/service.py
Outdated
| return list(self._urgent_windows) | ||
|
|
||
| @IgnisProperty | ||
| def urgent_workspaces(self) -> list[str]: |
There was a problem hiding this comment.
Okay, maybe HyprlandWindow and HyprlandWorkspace should simply have is_urgent property? Instead of making separate lists
There was a problem hiding this comment.
I like that, how would you bind to urgent though? Do you just bind to the windows property at that point?
There was a problem hiding this comment.
HyprlandWindow (and HyprlandWorkspace) are GObjects too, so you can bind to them
There was a problem hiding this comment.
It wouldn't support binding to both properties under HyprlandWindow and the hyprland service though. I might be over-complicating it but how would I do what I'm doing in hyprland_workspaces() in the example bar?
2 participants
Support a list of urgent windows and corresponding workspaces. Cancels the urgent flag when the urgent window becomes active.