fix(auth): enforce trusted OAuth identity attributes - #688
Conversation
Signed-off-by: ylhu16 <ylhu16@iflytek.com>
|
ylhu16 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Review finding (blocking): |
FenjuFu
left a comment
There was a problem hiding this comment.
Rechecked current head 833270b. The Component import is restored, so the earlier compilation blocker is resolved. The identity-binding path now rejects system, merged, pending, and disabled accounts before profile mutation; only verified email is persisted; and the focused tests plus Server, E2E, Web, Docs, Dependency Review, and DCO checks pass. I found no new code blocker. This is not an approval yet because CLA remains pending and the branch is currently unmergeable; recheck the final head after those gates are resolved.
What
Why
How
Testing
cd server && ./mvnw -pl skillhub-auth -am -DskipTests installcd server/skillhub-auth && ../mvnw test -Dtest=IdentityBindingServiceTest,OAuthLoginFlowServiceTest,GitHubClaimsExtractorTest,AccessPolicyTestImpact