Coalesce the global command re-query - #4164
Open
siegfriedpammer wants to merge 1 commit into
Open
siegfriedpammer wants to merge 1 commit into
siegfriedpammer wants to merge 1 commit into
Conversation
A raise walks every bound menu item and toolbar button and re-evaluates its CanExecute, so a caller reporting a burst of state changes paid for that walk once per change. WPF's CommandManager, which this class documents itself as mirroring, coalesces to an idle-priority raise; do the same. The pending flag stays set for the duration of the raise, so an invalidation issued by a CanExecute handler folds into the raise in progress instead of posting another one and never draining. Assisted-by: Claude:claude-opus-5[1m]:Claude Code Assisted-by: OpenCode:openai/gpt-5.5:OpenCode
siegfriedpammer
force-pushed
the
perf/coalesce-command-requery
branch
from
September 21, 2026 15:52
0593a53 to
1ee8b32
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command re-query walks bound commands and re-evaluates CanExecute. Post one background-priority raise for a burst of invalidations so callers do not pay that cost once per state change.
Verification: not run separately; split from #4157.
This PR description was written by an AI agent (OpenCode gpt-5.5) working under @siegfriedpammer's direction.