Skip to content

fix: resolve TS2352 blocking CI + platform-neutral update label#240

Merged
icebear0828 merged 2 commits intomasterfrom
fix/ci-ts-error-and-update-label
Mar 27, 2026
Merged

fix: resolve TS2352 blocking CI + platform-neutral update label#240
icebear0828 merged 2 commits intomasterfrom
fix/ci-ts-error-and-update-label

Conversation

@icebear0828
Copy link
Copy Markdown
Owner

Summary

  • TS2352 修复: account-persistence.ts:189as Record<string, unknown> 类型断言在 tsc --strict 下报 TS2352,改为 in 运算符检查。此错误导致 v2.0.19 起所有平台(Windows/Mac/Linux)CI 构建失败,release 停滞在 v2.0.18
  • 更新按钮文案: "Download Latest DMG"/"下载最新 DMG" → "Download Latest Version"/"下载最新版本",Windows/Linux 用户不再看到 macOS 专属格式

Test plan

  • npm run build 无 TS 错误
  • npm test 118 files / 1382+ tests 全通过
  • 合并后触发 release workflow,验证 Windows/Mac/Linux 构建均成功
  • Windows Electron 用户收到自动更新通知

Cover 4 scenarios: server returns new RT, returns null, omits field,
and oaistb_rt_ without new RT. All must preserve existing RT.
- Replace `as Record<string, unknown>` with `in` operator check in
  account-persistence.ts to fix TS2352 that broke all CI builds since v2.0.19
- Change "Download Latest DMG" to "Download Latest Version" (EN/ZH)
  so Windows/Linux users see correct wording
@icebear0828 icebear0828 merged commit 7325324 into master Mar 27, 2026
1 check passed
@icebear0828 icebear0828 deleted the fix/ci-ts-error-and-update-label branch March 27, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant