fix: never clear existing refresh token during token update#237
Merged
icebear0828 merged 1 commit intomasterfrom Mar 27, 2026
Merged
fix: never clear existing refresh token during token update#237icebear0828 merged 1 commit intomasterfrom
icebear0828 merged 1 commit intomasterfrom
Conversation
updateToken could overwrite a valid RT with null/undefined when the Auth0 refresh response omitted the refresh_token field. This caused permanent RT loss — accounts became unable to auto-refresh. - updateToken signature changed to `refreshToken?: string` (no null) - Guard: only replace RT with a non-empty string value - addAccount dedup path uses the same guard - Remove oaistb_rt_ special branch that explicitly set RT to null
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateTokencould overwrite a valid RT withnull/undefinedwhen Auth0 refresh response omitted therefresh_tokenfield, causing permanent RT lossupdateTokensignature torefreshToken?: string(removed| null)addAccountdedup pathoaistb_rt_special branch that explicitly set RT tonullTest plan