Skip to content

depend on success for coverage upload#854

Merged
mshriver merged 1 commit into
ibutsu:mainfrom
mshriver:action-tweak
May 26, 2026
Merged

depend on success for coverage upload#854
mshriver merged 1 commit into
ibutsu:mainfrom
mshriver:action-tweak

Conversation

@mshriver
Copy link
Copy Markdown
Contributor

@mshriver mshriver commented May 26, 2026

Summary by Sourcery

Restrict coverage upload jobs in CI workflows to run only when their dependent test jobs succeed.

CI:

  • Update backend coverage upload job to depend on a successful backend test run instead of always executing.
  • Update frontend coverage upload job to depend on a successful lint/test run instead of always executing.

Copilot AI review requested due to automatic review settings May 26, 2026 15:20
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 26, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts GitHub Actions workflows so that coverage upload jobs only run when their dependent test jobs succeed, rather than always running.

File-Level Changes

Change Details Files
Gate coverage upload jobs on successful completion of their dependent test workflows in GitHub Actions.
  • Change backend coverage upload job condition from always running to only running when the test-backend job result is success
  • Change frontend coverage upload job condition from always running to only running when the lint-test-frontend job result is success
.github/workflows/tests-backend.yaml
.github/workflows/tests-frontend.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions CI workflows so coverage upload jobs run only when their dependent test jobs succeed, rather than running unconditionally.

Changes:

  • Frontend: gate the upload-coverage job on the lint-test-frontend job succeeding.
  • Backend: gate the upload-coverage job on the test-backend job succeeding.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/tests-frontend.yaml Adjusts the frontend coverage upload job condition to run only on successful lint/test.
.github/workflows/tests-backend.yaml Adjusts the backend coverage upload job condition to run only on successful tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/tests-frontend.yaml Outdated
Comment thread .github/workflows/tests-backend.yaml Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.44%. Comparing base (5b10ef0) to head (242839f).

❌ Your project check has failed because the head coverage (73.44%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #854   +/-   ##
=======================================
  Coverage   73.44%   73.44%           
=======================================
  Files         154      154           
  Lines        7562     7562           
  Branches      662      662           
=======================================
  Hits         5554     5554           
  Misses       1788     1788           
  Partials      220      220           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b10ef0...242839f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Claude <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@mshriver mshriver merged commit 0e530ad into ibutsu:main May 26, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants