Get unittest to 100% #212
Open
Get unittest to 100% #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wiotp no longer supports quickstart so had to remove all code specific to it and remove or edit any tests reliant upon it.
changed the dsc tests to be skipped if the environment variables haven't been set that are required for the target
moved some static methods out of classes as they didn't need to be in there and it causes backwards compatabilitiy with python2 (I know we don't officially support it but figured for customers using 0.11.0 it would be nice if 0.12.0 has a chance of working - if we ever do version 1.0.0 then can remove it completely)
other minor tweaks
Added tests specifically for paho mqtt 1.6.1 and 2.0.0 to check compatability with both versions
using tox can get 100% pass rate (with some tests skipped) for the default set of environments