Refactor NoApps NoProducts and NoApis blocks #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the block code from the ibm_apim/ibm_apim.emptycontent.inc Drupal 7 legacy file for NoApps, NoProducts and NoApis. That just leaves NoBlogs in the .inc file. That block can be considered separately under a different issue.
The blocks are implemented as block plugins. I have kept the block classes as simple and brief as possible and copied the block content into twig files. I have also moved the block plugins and templates into their respective modules: ibm_apis, products and ibm_apps which seemed the natural place to put them.
The text in the blocks is passed to the twig 't' function which i believe is a drupal twig extension function that makes the text translatable.