IBX-10758: Overflow list #54
Open
+339
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements an overflow list component for the Ibexa design system that automatically manages the display of list items based on available container width. When items exceed the container width, they are hidden and a "more" indicator shows the count of hidden items.
- Adds a new OverflowList Twig component with validation and template generation
- Implements TypeScript functionality for dynamic item hiding/showing based on container resize
- Updates ESLint configuration to allow specific magic numbers used in the overflow logic
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/Twig/Components/OverflowList.php | New Twig component class with props validation and template property generation |
| src/bundle/Resources/views/themes/standard/design_system/components/overflow_list.html.twig | Twig template for rendering the overflow list with item and "more" templates |
| src/bundle/Resources/public/ts/init_components.ts | Component initialization registration for overflow list instances |
| src/bundle/Resources/public/ts/components/oveflow_list.ts | Main TypeScript implementation with resize handling and item visibility management |
| eslint.config.mjs | ESLint configuration update to allow specific magic numbers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
GrabowskiM
force-pushed
the
IBX-10758-overflow-list
branch
from
09b0932 to
145c418
Compare
GrabowskiM
force-pushed
the
IBX-10758-overflow-list
branch
from
1cefefd to
6d7a86e
Compare
GrabowskiM
force-pushed
the
IBX-10758-overflow-list
branch
from
6c73782 to
e3d6e0a
Compare
albozek
approved these changes
Oct 23, 2025
| item: this.getTemplate('item'), | ||
| itemMore: this.getTemplate('item_more'), | ||
| }; | ||
|
|
| private getItems(getOnlyVisible = false, withOverflow = true): HTMLDivElement[] { | ||
| const itemsSelector = `:scope > *${getOnlyVisible ? ':not([hidden])' : ''}`; | ||
| const items = Array.from(this._itemsNode.querySelectorAll<HTMLDivElement>(itemsSelector)); | ||
|
|
There was a problem hiding this comment.
Nitpick: WDYT about changing to this? then no need to create an additional string, and it looks a bit more readable.
let items = [];
if(getOnlyVisible) {
items = Array.from(this._itemsNode.querySelectorAll(':scope > *:not([hidden])'))
} else {
items = Array.from(this._itemsNode.children);
}
| } | ||
|
|
||
| public rerender() { | ||
| let stopRecalculating = true; |
There was a problem hiding this comment.
Suggested change
| let stopRecalculating = true; | |
| let stopRecalculating = true; | |
dew326
approved these changes
Oct 24, 2025
| item: '', | ||
| itemMore: '', | ||
| }; | ||
|
|
|
|
||
| if (hiddenCount > 0) { | ||
| const tempMoreItem = document.createElement('div'); | ||
| tempMoreItem.innerHTML = this._templates.itemMore.replace('{{ hidden_count }}', hiddenCount.toString()); |
There was a problem hiding this comment.
Suggested change
| tempMoreItem.innerHTML = this._templates.itemMore.replace('{{ hidden_count }}', hiddenCount.toString()); | |
| tempMoreItem.innerHTML = this._templates.itemMore.replace('{{ hidden_count }}', hiddenCount.toString()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: