Skip to content

Add the ability to broadcast the discovery query on a different IP. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denhippie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add the ability to broadcast the discovery query on a different IP. #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pyharmony/discovery.py
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def deserialize_response(self, response):
pairs[key_value[0]] = key_value[1]
return pairs

def discover(self, scan_attempts, scan_interval):
def discover(self, scan_attempts, scan_interval, broadcast_ip):
# https://ruslanspivak.com/lsbaws-part1/
listen_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
listen_socket.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
Expand Down Expand Up @@ -79,7 +79,7 @@ def discover(self, scan_attempts, scan_interval):
for scan in range(0, scan_attempts):
try:
logger.debug('Pinging network on port %s', PORT_TO_ANNOUNCE)
ping_sock.sendto(MESSAGE, ('255.255.255.255', 5224))
ping_sock.sendto(MESSAGE, (broadcast_ip, 5224))
except Exception as e:
logger.error('Error pinging network: %s', e)

Expand All @@ -94,7 +94,7 @@ def discover(self, scan_attempts, scan_interval):
return [hubs[h] for h in hubs]


def discover(scan_attempts=10, scan_interval=1):
def discover(scan_attempts=10, scan_interval=1, broadcast_ip='255.255.255.255'):
"""Creates a Harmony client and initializes session.

Args:
Expand All @@ -104,4 +104,4 @@ def discover(scan_attempts=10, scan_interval=1):
Returns:
A list of Hub devices found and their configs
"""
return Discovery().discover(scan_attempts, scan_interval)
return Discovery().discover(scan_attempts, scan_interval, broadcast_ip)