fix(docker): keep devDependencies out of production image#84
Merged
Conversation
Co-authored-by: Luke The Dev <iamlukethedev@users.noreply.github.com>
comu-ops
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dockerfiledepswithnpm ci --ignore-scripts --omit=devbuildersonpm run buildstill succeedsnode_modulesfor runtime fromdeps(prod-only) instead of frombuilderIssue verification
The reported issue is valid for the Dockerfile introduced in PR #82 (
add-dockerfile):depsrannpm ci --ignore-scriptswithout--omit=devrunnercopiednode_modulesfrombuilderThat means devDependencies (Playwright, Vitest, ESLint, jsdom, etc.) ended up in the production image, increasing size and attack surface.
Result
The final
runnerimage now contains only production dependencies while preserving a full dependency set where required for building.Testing
node_modules.