add missing regional indicators for img-google#219
add missing regional indicators for img-google#219successtheman wants to merge 1 commit intoiamcal:masterfrom
Conversation
This adds the missing regional indicators to fix this issue here (only for Google Emoji) iamcal#167
|
Are these ever going to be added to the repo? it's a key emoji which is missing still |
|
This won't work. You can't just copy the files. You need to modify the build scripts to include the indicators. I did that in Nerixyz@be5a8a2. I didn't rebuild the images nor did I grab the images, because the compression takes ages. |
I had no idea, thanks for explaining it, I guess I'll just wait and see if yours gets merged? From my understanding now, rebuilding/grabbing the images doesn't need to be done for the PR to be accepted as long as the build script is altered? |
Yea. Although, I don't know if this project is still alive. But feel free to take my changes to the script, the data file, and rebase them on |
This adds the missing regional indicators to fix this issue here (only for Google Emoji) #167. This doesn't fix the other emoji sets, I will not be fixing those (others are welcome to do so however)