Skip to content

Comments

add missing regional indicators for img-google#219

Open
successtheman wants to merge 1 commit intoiamcal:masterfrom
YAGPDBstuff:master
Open

add missing regional indicators for img-google#219
successtheman wants to merge 1 commit intoiamcal:masterfrom
YAGPDBstuff:master

Conversation

@successtheman
Copy link

This adds the missing regional indicators to fix this issue here (only for Google Emoji) #167. This doesn't fix the other emoji sets, I will not be fixing those (others are welcome to do so however)

This adds the missing regional indicators to fix this issue here (only for Google Emoji) iamcal#167
@successtheman
Copy link
Author

successtheman commented Dec 20, 2024

Are these ever going to be added to the repo? it's a key emoji which is missing still

@Nerixyz
Copy link
Contributor

Nerixyz commented Feb 15, 2025

This won't work. You can't just copy the files. You need to modify the build scripts to include the indicators. I did that in Nerixyz@be5a8a2. I didn't rebuild the images nor did I grab the images, because the compression takes ages.

@successtheman
Copy link
Author

This won't work. You can't just copy the files. You need to modify the build scripts to include the indicators. I did that in Nerixyz@be5a8a2. I didn't rebuild the images nor did I grab the images, because the compression takes ages.

I had no idea, thanks for explaining it, I guess I'll just wait and see if yours gets merged? From my understanding now, rebuilding/grabbing the images doesn't need to be done for the PR to be accepted as long as the build script is altered?

@Nerixyz
Copy link
Contributor

Nerixyz commented Feb 16, 2025

From my understanding now, rebuilding/grabbing the images doesn't need to be done for the PR to be accepted as long as the build script is altered?

Yea. Although, I don't know if this project is still alive. But feel free to take my changes to the script, the data file, and rebase them on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants