Skip to content

chore: remove tooltip of terminal tab #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove tooltip of terminal tab #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions nxshell/src/ui/tab_view/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use crate::app::{NxShell, NxShellOptions};
use crate::consts::GLOBAL_COUNTER;
use crate::ui::tab_view::session::SessionList;
use copypasta::ClipboardContext;
use egui::{Label, Response, Sense, Ui};
use egui::{Label, Sense, Ui};
use egui_dock::tab_viewer::OnCloseResponse;
use egui_dock::{DockArea, Style};
use egui_phosphor::regular::{DRONE, NUMPAD};
Expand Down Expand Up @@ -139,22 +139,6 @@ impl egui_dock::TabViewer for TabViewer<'_> {
}
}

fn on_tab_button(&mut self, tab: &mut Self::Tab, response: &Response) {
if response.hovered() {
if let TabInner::Term(term) = &mut tab.inner {
if let TermType::Ssh { options } = &term.term_type {
if let Authentication::Password(..) = options.auth {
response.show_tooltip_text(format!(
"{}:{}",
options.host,
options.port.unwrap_or(22)
));
}
}
}
}
}

fn closeable(&mut self, tab: &mut Self::Tab) -> bool {
matches!(&mut tab.inner, TabInner::Term(_))
}
Expand Down
Loading