Fix: Inherit Custom Exceptions from Exception - #50
Conversation
The custom exceptions `UnsupportedFileError` and `VisionParserError` were inheriting from `BaseException`. This caused issues with standard error handling, as `except Exception:` blocks would not catch these exceptions. This commit changes the base class for these exceptions to `Exception`, ensuring they are caught by standard exception handling and making the error handling more robust and predictable.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change corrects the inheritance of custom exceptions in
src/vision_parse/parser.pyto ensure they are caught by standardexcept Exception:blocks. The base class forUnsupportedFileErrorandVisionParserErrorhas been changed fromBaseExceptiontoException.PR created automatically by Jules for task 16596755132177738663