Image fps improvement - #200
Merged
Merged
Conversation
* benchmark code + bucket 0 * bucket 1 * bucket 2 * bucket 3 * bucket 4 * bucket 5 * bucket 6 * Measurements * bucket 8: bgr packing instead of bgra * Bucket 9: shared-memory ring buffer * Bucket 10 — Instrumentation and Development Baseline * save measurements csvs * WIP DDS qos modification * DELETE ME: added artifact test dir just in case, to track * Measure keep_last=5 with dds 256MiB * Revert bgr packing optimization. It didn't improve * Remove shared-memory ring code * Remove image FPS benchmark instrumentation and artifacts * CPU improvements + step() API (#162) * add CPU usage profiling tests and multi-drone lift-land test cases * refactor: optimize CPU usage by eliminating non-blocking recv spin and implementing recv timeout * Add step API * Comment GetImages() based cpu tests * Remove unnecessary files * Rename 'drones' to 'robots' * Delete UE_ROOT secret usage in self-hosted workflow * Fix build for ue5.2 * Add suport for jsbsim for variable ue version (5.2 and 5.7) --------- Co-authored-by: Zaffer <51871197+Zaffer@users.noreply.github.com> * WIP rebase fixing * remove binary non-used custom image methods * Add ros2 custom DDS profile documentation * fix build rover test * Add missing fastdds profile file --------- Co-authored-by: UE <unrealempowerment@gmail.com> Co-authored-by: Zaffer <51871197+Zaffer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across both the Python client and the C++ core simulation components, focusing on more robust connection management, improved serialization performance, and enhanced topic handling. The changes include the addition of a service-only connection mode for the Python client, optimizations to image message serialization in C++, and more reliable and thread-safe topic connection tracking in the core simulator.
Python client enhancements:
connect_servicesmethod toProjectAirSimClientto allow connecting only to the service socket, which is useful when another process owns the topic socket (e.g., for ROS bridge integration). (client/python/projectairsim/src/projectairsim/client.py)client/python/projectairsim/src/projectairsim/client.py) [1] [2] [3] [4]StaticSensorActorto the public API. (client/python/projectairsim/src/projectairsim/__init__.py)C++ core simulation improvements:
ImageMessageserialization by replacingstd::stringstreamwith a custom buffer, reducing allocations and improving efficiency. (core_sim/src/message/image_message.cpp) [1] [2]core_sim/src/topic_manager.cpp)core_sim/src/topic_manager.cpp) [1] [2] [3] [4] [5] [6]core_sim/src/topic_manager.cpp) [1] [2] [3]Build and dependency cleanups:
core_sim/src/CMakeLists.txt,client/cpp/ProjectAirsimClientLib/src/Topics.h,core_sim/src/message/image_message.cpp,core_sim/src/sensors/camera.cpp) [1] [2] [3] [4]ONNX model post-processing:
core_sim/src/sensors/camera.cpp)These changes collectively improve the reliability, efficiency, and extensibility of both the client and core simulation components.