Preserve explicit TreeFocus overrides across Obsidian reloads#7
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix folder focus disappearing on reload
Preserve explicit TreeFocus overrides across Obsidian reloads
May 27, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes intermittent loss of persisted explicit TreeFocus overrides across Obsidian reloads by changing startup cleanup to validate overrides against vault existence rather than transient File Explorer render state.
Changes:
- Reworked
performPluginCleanupTask()orphan detection to useapp.vault.getAbstractFileByPath(path) === null. - Removed File Explorer traversal during cleanup so explicit overrides aren’t dropped just because nodes aren’t rendered yet.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit folder/file focus overrides could be dropped on reload because startup cleanup treated non-rendered File Explorer items as orphaned. This led to intermittent loss of saved focused views despite paths still existing in the vault.
Problem
Change
performPluginCleanupTask()to validate persisted override paths against vault existence, not UI visibility.Behavioral impact
fileOverwritessurvive reloads unless the underlying file/folder was actually deleted.