Merged
Conversation
- Move virewer_app into edda to fix viewer launching on package installation
i2y
approved these changes
Feb 2, 2026
Owner
i2y
left a comment
i2y
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix.
Minor note) The docstring in viewer_app.py (line 39) still references uv run python viewer_app.py. Feel free to update it to uv run python -m edda.viewer_app in this PR or a follow-up or something.
Owner
|
@SoumyaRanjanNaik Thanks! I'll merge this and add a small fix for the CI/mypy error (nicegui import) in a follow-up commit. |
Contributor
Author
Let me raise another one to fix this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2