Skip to content

fix: scale animation playback rate with entity height (fixes SDK #27) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cryptochris8 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: scale animation playback rate with entity height (fixes SDK #27) #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions server/src/worlds/entities/controllers/DefaultPlayerEntityController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,23 +594,26 @@ export default class DefaultPlayerEntityController extends BaseEntityController
}

// Handle movement animations and audio
const scaleMultiplier = entity.height / DefaultPlayerEntityController.BASE_ENTITY_HEIGHT;
if (this.isGrounded && !this.isSwimming && this._isActivelyMoving && !hasConflictingInputs && canMove) {
// Ground movement animations
const animations = isFastMovement ? this.runLoopedAnimations : this.walkLoopedAnimations;
entity.stopAllModelAnimations(animation => animations.includes(animation.name) || animation.loopMode === EntityModelAnimationLoopMode.ONCE);
for (const animation of animations) {
entity.getModelAnimation(animation)?.setLoopMode(EntityModelAnimationLoopMode.LOOP);
entity.getModelAnimation(animation)?.play();
entity.getModelAnimation(animation)?.setPlaybackRate(scaleMultiplier);
}
this._stepAudio?.setPlaybackRate(isFastMovement ? 0.75 : 0.51);
this._stepAudio?.setPlaybackRate((isFastMovement ? 0.75 : 0.51) * scaleMultiplier);
this._stepAudio?.play(entity.world, !this._stepAudio?.isPlaying);
} else if (this._isFullySubmerged && this.canSwim(this)) {
this._stepAudio?.pause();
if (this._isActivelyMoving) {
entity.stopAllModelAnimations(animation => this.swimLoopedAnimations.includes(animation.name) || animation.loopMode === EntityModelAnimationLoopMode.ONCE);
for (const animation of this.swimLoopedAnimations) {
for (const animation of this.swimLoopedAnimations) {
entity.getModelAnimation(animation)?.setLoopMode(EntityModelAnimationLoopMode.LOOP);
entity.getModelAnimation(animation)?.play();
entity.getModelAnimation(animation)?.setPlaybackRate(scaleMultiplier);
}
} else {
entity.stopAllModelAnimations(animation => this.swimIdleLoopedAnimations.includes(animation.name) || animation.loopMode === EntityModelAnimationLoopMode.ONCE);
Expand Down