-
-
Notifications
You must be signed in to change notification settings - Fork 3
[WIP] add session lock support #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PaideiaDilemma
wants to merge
10
commits into
hyprwm:main
Choose a base branch
from
PaideiaDilemma:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0c9e26a
add CWaylandOutput
PaideiaDilemma d6968da
add WaylandLockSurface
PaideiaDilemma 8dacdaa
add CCExtSessionLockV1
PaideiaDilemma 821a1a7
add IOutput
PaideiaDilemma 22dc12a
add better emit of outputAdded
PaideiaDilemma 98190d3
add m_lockSurfaces to windowForSurf to make click work
PaideiaDilemma 3b2fd78
handle CCExtSessionLockV1 finished event
PaideiaDilemma 5fac7c0
add needed stuff to IOutput
PaideiaDilemma 0b06f6e
remove CBackend::attempt
PaideiaDilemma d44b793
add lockDenied event to the backend
PaideiaDilemma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ | |
|
|
||
| namespace Hyprtoolkit { | ||
| class IWindow; | ||
| class IOutput; | ||
| class CTimer; | ||
| class ISystemIconFactory; | ||
| struct SWindowCreationData; | ||
|
|
@@ -73,6 +74,26 @@ namespace Hyprtoolkit { | |
|
|
||
| Hyprutils::Memory::CSharedPointer<CPalette> getPalette(); | ||
|
|
||
| void unlockSession(); | ||
|
|
||
| /* | ||
| Get currently registered outputs. | ||
| Make sure you register the `removed` event to get rid of your reference once the output is removed. | ||
| */ | ||
| std::vector<Hyprutils::Memory::CSharedPointer<IOutput>> getOutputs(); | ||
|
|
||
| struct { | ||
| /* | ||
| Get notified when a new output was added. | ||
| */ | ||
| Hyprutils::Signal::CSignalT<Hyprutils::Memory::CSharedPointer<IOutput>> outputAdded; | ||
|
|
||
| /* | ||
| Sent when the compositor denies us as the exclusive lock screen client. | ||
| */ | ||
| Hyprutils::Signal::CSignalT<> lockDenied; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this could be moved to the ILockState mentioned above |
||
| } m_events; | ||
|
|
||
| HT_HIDDEN : CBackend(); | ||
|
|
||
| void terminate(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| #pragma once | ||
|
|
||
| #include <hyprutils/signal/Signal.hpp> | ||
| #include <hyprutils/math/Vector2D.hpp> | ||
|
|
||
| namespace Hyprtoolkit { | ||
| class IOutput { | ||
| public: | ||
| virtual ~IOutput() = default; | ||
| virtual uint32_t handle() = 0; | ||
| virtual std::string port() = 0; | ||
| virtual std::string desc() = 0; | ||
|
|
||
| struct { | ||
| // output removed | ||
| Hyprutils::Signal::CSignalT<> removed; | ||
| } m_events; | ||
PaideiaDilemma marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kinda sucks. I'd rather you'd make some lock state controller.
ILockState that you can get from the backend if you have a lockscreen, and will return nullptr if you dont.
This would play nicely with making Lock Surfaces -> you can only make them once you obtain the lockstate.
std::expected<SP<ILockState>, eLockError> createSystemLock();