feat(tokens): hide legacy non-upgradeable Hypha Platform tokens (HCREDITS, HVOICE)#2312
feat(tokens): hide legacy non-upgradeable Hypha Platform tokens (HCREDITS, HVOICE)#2312n0umen0n wants to merge 2 commits into
Conversation
Updated multiple asset retrieval routes to exclude hidden tokens using the new isHiddenToken utility. This change ensures that deprecated or non-visible tokens are not included in the token lists returned by the API, enhancing the clarity and relevance of the data presented to users.
Add the Hypha Platform (space 241) HVOICE contract to the hidden-token denylist. Like HCREDITS, it is a non-upgradeable, directly-deployed legacy token that cannot be managed via governance. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
More reviews will be available in 13 minutes and 30 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔗 Custom preview URL: https://pr-2312.preview-app.hypha.earth |
Summary
The Hypha Platform space (web3 space id 241) has two legacy space tokens — HCREDITS (
0xb8591aDE4ceDA2dd14B1924dC81D23B765C2820d) and HVOICE (0x24e0b2bfee025d57a19f9dae4c3849a4a6bf9626). On-chain investigation showed both are directly-deployed, non-proxy contracts:upgradeTo/upgradeToAndCall/proxiableUUID→ not upgradeable.isAuthorizedMinter), and theirburnFromlacks the executor privilege the current burn-proposal flow relies on, so they can't be burned via a DAO proposal either.Since they can't be upgraded or retired through governance, this PR hides them from the UI so they no longer appear in treasuries, profiles, holder breakdowns, transfer pickers, or vaults. (New replacement tokens issued through the current factory get new addresses and are unaffected.)
Changes
HIDDEN_TOKEN_ADDRESSESdenylist +isHiddenToken()helper inpackages/core/src/common/web3/tokens.ts.spaces/[spaceSlug]/assetsandassets-without-balances)people/[personSlug]/assets)getTokenHoldingsBySpaceSlug)wallet-transferable-tokens)spaces/[spaceSlug]/vaults)findAllTokens)Filters run after the Hypha-Platform shared-token injection in
getTokenHoldingsBySpaceSlug, so the denylist still wins there. Filters are placed before the per-token RPC/multicall work, so the heavier endpoints make slightly fewer calls.Test plan
hypha-platformexcludes both tokensMade with Cursor