fix(calls): apply CodeRabbit diagnostics and test hygiene from #2310#2311
Conversation
|
Warning Review limit reached
More reviews will be available in 16 minutes and 12 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔗 Custom preview URL: https://pr-2311.preview-app.hypha.earth |
Reset the mocked Permissions API between tests so global state does not leak across cases in call-camera-access.test.ts. Co-authored-by: Cursor <cursoragent@cursor.com>
Wrap peerConnection.getStats() in try/catch so teardown does not surface unhandled rejections from fire-and-forget diagnostics logging. Co-authored-by: Cursor <cursoragent@cursor.com>
Collect RTCPeerConnection stats once per peer per interval and feed the same snapshot to frame-size and ICE transport logging. Co-authored-by: Cursor <cursoragent@cursor.com>
Use regex matchers for source-scan assertions so formatting-only edits do not break the screenshare takeover manual gate tests. Co-authored-by: Cursor <cursoragent@cursor.com>
webguru-hypha
force-pushed
the
fix/coderabbit-call-diagnostics
branch
from
c5791f9 to
2029c0b
Compare
1 participant
Summary
navigator.permissionsbetween camera access unit tests to avoid global-state bleedgetStats()calls during peer teardown and reuse one stats snapshot per peer per tickFollow-up to merged #2310 — addresses unresolved CodeRabbit review threads that landed after that PR was merged.
Test plan
pnpm --filter @hypha-platform/core exec vitest run src/matrix/client/hooks/__tests__/call-camera-access.test.tspnpm --filter @hypha-platform/epics exec vitest run src/common/human-chat-panel/__tests__/call-regression-manual-gates.test.tsMade with Cursor