Add daml models for token std based merging #2438
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Kiefer <[email protected]>
meiersi-da
reviewed
Sep 26, 2025
| # Proxy contracts for delegating the usage of featured app rights | ||
|
|
||
| This is a convenience package that provides proxy contracts that allow for the | ||
| delegation of featured app rights to other parties for the usage of token |
| do let transfer = choiceArg.transfer | ||
| require ("Sender in choice argument " <> show transfer.sender <> " matches owner " <> show owner) (transfer.sender == owner) | ||
| require ("Receiver in choice argument " <> show transfer.receiver <> " matches owner " <> show owner) (transfer.receiver == owner) | ||
| -- Note: This assumes you have preapprovals, if not you also need to accept the transfer instruction here. |
There was a problem hiding this comment.
Self transfers do not require pre-approvals... however did you want to do a combined send with merge?
There was a problem hiding this comment.
oh nice I totally missed that we have special handling for self-transfers. Excellent, will remove.
There was a problem hiding this comment.
however did you want to do a combined send with merge?
No I'd just do a merge only
There was a problem hiding this comment.
ack. I'll finish the review then. You'll probably nevertheless want to assert on the result being TransferResult_Completed
There was a problem hiding this comment.
You'll probably nevertheless want to assert on the result being TransferResult_Completed
added
Signed-off-by: Moritz Kiefer <[email protected]>
Signed-off-by: Moritz Kiefer <[email protected]>
meiersi-da
reviewed
Sep 26, 2025
...l-delegation-test/daml/Splice/Util/MergeDelegation/IntegrationTests/TestMergeDelegation.daml
Outdated
Show resolved
Hide resolved
...l-delegation-test/daml/Splice/Util/MergeDelegation/IntegrationTests/TestMergeDelegation.daml
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon Meier <[email protected]> Signed-off-by: moritzkiefer-da <[email protected]>
Signed-off-by: Moritz Kiefer <[email protected]>
Signed-off-by: Moritz Kiefer <[email protected]>
Signed-off-by: Moritz Kiefer <[email protected]>
meiersi-da
reviewed
Sep 26, 2025
| values = TextMap.fromList [("splice.lfdecentralizedtrust.org/reason", "merge")] | ||
| extraArgs = emptyExtraArgs | ||
|
|
||
| submit (actAs delegate <> readAs owner<> discloseMany (Map.values enrichedChoice.disclosures.disclosures)) $ exerciseCmd delegation MergeDelegation_Merge with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines