Prevent txlog backfill from including ACS imports #2128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oriol Muñoz <[email protected]>
OriolMunoz-da
force-pushed
the
oriol/txlogbackfill-no-acs-import
branch
from
59fc489 to
eaca3c8
Compare
Signed-off-by: Oriol Muñoz <[email protected]>
OriolMunoz-da
commented
Sep 4, 2025
Comment on lines
+609
to
+616
| Future.successful( | ||
| DestinationHistory.InsertResult( | ||
| backfilledUpdates = 0L, | ||
| backfilledEvents = 0L, | ||
| lastBackfilledRecordTime = | ||
| items.headOption.map(_.update.recordTime).getOrElse(CantonTimestamp.MinValue), | ||
| ) | ||
| .transactionally, | ||
| "destinationHistory.insert", | ||
| ) | ||
| } yield DestinationHistory.InsertResult( | ||
| backfilledUpdates = trees.size.toLong, | ||
| backfilledEvents = | ||
| trees.foldLeft(0L)((sum, tree) => sum + tree.getEventsById.size().toLong), | ||
| lastBackfilledRecordTime = CantonTimestamp.assertFromInstant(nonEmpty.last.getRecordTime), | ||
| ) | ||
| ) |
There was a problem hiding this comment.
here be dragons, I don't understand why the previous was throwing an exception
Signed-off-by: Oriol Muñoz <[email protected]>
There was a problem hiding this comment.
Can you remind me how exactly you got an exception here? The method includes the assertion
assert(
tree.getRecordTime.isAfter(CantonTimestamp.MinValue.toInstant),
"insert() must not be called with import updates",
)and looking at the call site (HistoryBackfilling), the method should really not be called with any items that have a record time of CantonTimestamp.MinValue.
|
@rautenrieth-da see this PR targeting this one which removes the filter, and these failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2041 (comment)