Skip to content

Conversation

@adecaro
Copy link
Contributor

@adecaro adecaro commented Aug 27, 2025

No description provided.

@adecaro adecaro self-assigned this Aug 27, 2025
@adecaro adecaro requested a review from mbrandenburger August 27, 2025 11:57
@mbrandenburger
Copy link
Member

mbrandenburger commented Sep 2, 2025

@adecaro this PR depends on hyperledger-labs/fabric-smart-client#1033, right?
If that is the case, better mark is as draft :)

@arner
Copy link
Contributor

arner commented Sep 2, 2025

We usually bind an alias in the form of view.Identity("my_account") to an actual identity, and it has always felt a bit hacky and hard to understand. It also leads to more database calls and duplication (only one "alias" per key). Aliases can be the local name or reference id to retrieve it in the node itself, a public identifier like an IBAN or Ethereum or other address, or something else. Maybe we can take a look at the data model, and whether it may be worthwhile doing something like adding a table for string aliases that can be joined to the identities table? Maybe it's even feasible with backwards compatibility.

@HayimShaul
Copy link

@adecaro @arner
Can you please explain you comment? is there any changes I should make?

@AkramBitar AkramBitar self-requested a review September 8, 2025 11:48
@adecaro
Copy link
Contributor Author

adecaro commented Sep 10, 2025

@arner , good point. Yesterday, I was discussing with @ale-linux about reworking the FSC's identity provider and endpoint service. Your comments will be used during that rework.

[email protected] and others added 2 commits September 10, 2025 05:50
Signed-off-by: Angelo De Caro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants