refactor!: opentelemetry naming #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcus Brandenburger <[email protected]>
mbrandenburger
added
cleanup
arner
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Nice that was bothering me already. This is a "soft" breaking change, in the sense that people have to update their core.yaml configuration. Two points here:
- Maybe we should start adding breaking changes like these at release notes for new tags? What do you think of using part of Conventional Commits? That would help automate the process.
- In this case it probably fails hard because it doesn't know the provider, so the user will find out soon enough. Maybe in general, should we validate the config to catch unused, missing or misspelled fields? It's a common source of bugs. See also #209 and #410.
cc @adecaro
adecaro
reviewed
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses (#643) the naming inconsistency of the opentelemetry component.
BREAKING CHANGE: this PR changes naming in the fsc
core.yaml