Skip to content

refactor!: Cleanups #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2025
Merged

refactor!: Cleanups #1060

merged 4 commits into from
Oct 27, 2025

Conversation

@mbrandenburger
Copy link
Member

@mbrandenburger mbrandenburger commented Oct 21, 2025 •
edited
Loading

This PR contains several cleanups

  • within the fabric-x package use imports from fabric-x-common where possible
  • remove redundant code for GenerateUUID
  • cleanup the use of our sha256 helper package Remove the hash helper package
  • use builtin max func

BREAKING CHANGE: This PR changes the NewChannelProvider of fabric sdk and other constructors as hash.Hasher got removed.

@mbrandenburger mbrandenburger self-assigned this Oct 21, 2025
@mbrandenburger mbrandenburger added the cleanup Something needs some cleanup label Oct 21, 2025
@mbrandenburger mbrandenburger added this to the Q4 milestone Oct 21, 2025
@mbrandenburger mbrandenburger force-pushed the cleanups branch 2 times, most recently from 9c8253b to 67b4c7d Compare October 23, 2025 07:25
@mbrandenburger
Copy link
Member Author

This PR removes platform/common/utils/hash:

  • we simply use sha256.Sum256 where applicable
  • Adding logging.Sha256Base64 as helper for logging
  • GetTLSCertHash was the only consumer of the hasher we injected via the SDK. This function now expliclity uses sha256.Sum256

@mbrandenburger
Remove fabric imports from fabric-x
9aa36ab 
Signed-off-by: Marcus Brandenburger <[email protected]>
@mbrandenburger
Remove redundant impl of GenerateUUID
a3ca38b 
Signed-off-by: Marcus Brandenburger <[email protected]>
@mbrandenburger
Remove hash utils
6828ee9 
Signed-off-by: Marcus Brandenburger <[email protected]>
@mbrandenburger
Use builtin max func
ffcba4b 
Signed-off-by: Marcus Brandenburger <[email protected]>
@mbrandenburger mbrandenburger changed the title Cleanups refactor!: Cleanups Oct 27, 2025
@mbrandenburger mbrandenburger requested a review from arner October 27, 2025 10:09
adecaro
adecaro approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Happy to see the code getting leaner. Thanks Marcus

@mbrandenburger mbrandenburger merged commit 9dff256 into hyperledger-labs:main Oct 27, 2025
20 checks passed
@mbrandenburger mbrandenburger deleted the cleanups branch October 27, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adecaro adecaro adecaro approved these changes

@arner arner Awaiting requested review from arner

Assignees

@mbrandenburger mbrandenburger

Labels

cleanup Something needs some cleanup

Projects

None yet

Milestone

25Q4

Development

Successfully merging this pull request may close these issues.

2 participants

@mbrandenburger @adecaro