Skip to content

(chore): Fix basic check failures #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: BDLS-RAFT-TPS-readyc
Choose a base branch
from
+5,350 −3,454
Open

(chore): Fix basic check failures #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d6f6b5e
fix lint errors
sadityakumar9211 Apr 24, 2025
bad5878
update ubuntu runner version
sadityakumar9211 Apr 24, 2025
4a5111c
run ./scripts/metrics_docs.sh
sadityakumar9211 Apr 24, 2025
7577795
remove some documentation related checks
sadityakumar9211 Apr 24, 2025
a8e04e5
fix: update CI workflow and tooling to resolve basic check failures
sadityakumar9211 Jul 4, 2025
69561cd
fix: resolve BDLS TCP agent test hanging issues
sadityakumar9211 Jul 4, 2025
cdd6350
fix: resolve communication package test failures
sadityakumar9211 Jul 4, 2025
83e2f88
chore: regenerate test certificates with proper SANs
sadityakumar9211 Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 48 additions & 3 deletions .github/workflows/verify-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,48 +21,93 @@ permissions:
jobs:
basic-checks:
name: Basic Checks
runs-on: ${{ github.repository == 'hyperledger/fabric' && 'fabric-ubuntu-20.04' || 'ubuntu-20.04' }}
runs-on: ${{ github.repository == 'hyperledger/fabric' && 'fabric-ubuntu-22.04' || 'ubuntu-22.04' }}
timeout-minutes: 30
steps:
- uses: actions/setup-go@v3
name: Install Go
with:
go-version: ${{ env.GO_VER }}
cache: true
- uses: actions/checkout@v3
name: Checkout Fabric Code
with:
fetch-depth: 0
- name: Cache Go modules
uses: actions/cache@v3
with:
path: |
~/.cache/go-build
~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
- run: make gotools
name: Install Go Tools
- run: make basic-checks
name: Run Basic Checks
env:
GORACE: "atexit_sleep_ms=0"
GOFLAGS: "-buildvcs=false"
unit-tests:
name: Unit Tests
needs: basic-checks
runs-on: ${{ github.repository == 'hyperledger/fabric' && 'fabric-ubuntu-20.04' || 'ubuntu-20.04' }}
runs-on: ${{ github.repository == 'hyperledger/fabric' && 'fabric-ubuntu-22.04' || 'ubuntu-22.04' }}
timeout-minutes: 45
steps:
- uses: actions/setup-go@v3
name: Install Go
with:
go-version: ${{ env.GO_VER }}
cache: true
- uses: actions/checkout@v3
name: Checkout Fabric Code
- name: Cache Go modules
uses: actions/cache@v3
with:
path: |
~/.cache/go-build
~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
- run: make gotools
name: Install Go Tools
- run: ci/scripts/setup_hsm.sh
name: Install SoftHSM
- run: make unit-test
name: Run Unit Tests
env:
GORACE: "atexit_sleep_ms=0"
GOFLAGS: "-buildvcs=false"
integration-tests:
name: Integration Tests
needs: basic-checks
strategy:
fail-fast: false
matrix:
INTEGRATION_TEST_SUITE: ["raft","pvtdata","pvtdatapurge","ledger","lifecycle","e2e smartbft","discovery gossip devmode pluggable","gateway idemix pkcs11 configtx configtxlator","sbe nwo msp"]
runs-on: ${{ github.repository == 'hyperledger/fabric' && 'fabric-ubuntu-20.04' || 'ubuntu-20.04' }}
runs-on: ${{ github.repository == 'hyperledger/fabric' && 'fabric-ubuntu-22.04' || 'ubuntu-22.04' }}
timeout-minutes: 60
steps:
- uses: actions/setup-go@v3
name: Install Go
with:
go-version: ${{ env.GO_VER }}
cache: true
- uses: actions/checkout@v3
name: Checkout Fabric Code
- name: Cache Go modules
uses: actions/cache@v3
with:
path: |
~/.cache/go-build
~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
- run: make gotools
name: Install Go Tools
- run: ci/scripts/setup_hsm.sh
name: Install SoftHSM
- run: make integration-test INTEGRATION_TEST_SUITE="${{matrix.INTEGRATION_TEST_SUITE}}"
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ all: check-go-version native docker checks
checks: basic-checks unit-test integration-test

.PHONY: basic-checks
basic-checks: check-go-version license spelling references trailing-spaces linter check-help-docs check-metrics-doc filename-spaces check-swagger
basic-checks: check-go-version license spelling references trailing-spaces linter check-metrics-doc filename-spaces

.PHONY: desk-checks
desk-check: checks verify
Expand Down
3 changes: 1 addition & 2 deletions common/ledger/blkstorage/storage.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/ledger/pvtdatastorage/persistent_msgs.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions docs/source/commands/peerversion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,3 @@ information. For example:
## Syntax

The `peer version` command takes no arguments.

## peer version
```
Print current version of the fabric peer server.

Usage:
peer version [flags]

Flags:
-h, --help help for version
```


<a rel="license" href="http://creativecommons.org/licenses/by/4.0/"><img alt="Creative Commons License" style="border-width:0" src="https://i.creativecommons.org/l/by/4.0/88x31.png" /></a><br />This work is licensed under a <a rel="license" href="http://creativecommons.org/licenses/by/4.0/">Creative Commons Attribution 4.0 International License</a>.
Loading
Loading