feat: add HeaderMap::try_ methods to handle capacity overflow
#682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
header-map-try-reserve
branch
from
3c71340 to
44d8216
Compare
seanmonstar
force-pushed
the
header-map-try-reserve
branch
from
44d8216 to
2c9de1c
Compare
glebpom
reviewed
Mar 2, 2024
glebpom
reviewed
Mar 3, 2024
seanmonstar
force-pushed
the
header-map-try-reserve
branch
from
2c9de1c to
8f49681
Compare
bobrik
added a commit
to bobrik/tonic
that referenced
this pull request
Oct 15, 2025
We use `try_insert`, which was added in v1.1.0: * hyperium/http#682 ``` error[E0599]: no method named `try_insert` found for mutable reference `&mut HeaderMap` in the current scope --> tonic/src/transport/channel/service/user_agent.rs:44:14 | 42 | if let Ok(Some(user_agent)) = req | _______________________________________- 43 | | .headers_mut() 44 | | .try_insert(USER_AGENT, self.user_agent.clone()) | |_____________-^^^^^^^^^^ | help: there is a method `insert` with a similar name | 44 - .try_insert(USER_AGENT, self.user_agent.clone()) 44 + .insert(USER_AGENT, self.user_agent.clone()) | ```
bobrik
added a commit
to bobrik/tonic
that referenced
this pull request
Oct 15, 2025
We use `try_insert`, which was added in v1.1.0: * hyperium/http#682 ``` error[E0599]: no method named `try_insert` found for mutable reference `&mut HeaderMap` in the current scope --> tonic/src/transport/channel/service/user_agent.rs:44:14 | 42 | if let Ok(Some(user_agent)) = req | _______________________________________- 43 | | .headers_mut() 44 | | .try_insert(USER_AGENT, self.user_agent.clone()) | |_____________-^^^^^^^^^^ | help: there is a method `insert` with a similar name | 44 - .try_insert(USER_AGENT, self.user_agent.clone()) 44 + .insert(USER_AGENT, self.user_agent.clone()) | ```
tottoto
added a commit
to hyperium/tonic
that referenced
this pull request
Oct 16, 2025
We use `try_insert`, which was added in v1.1.0: * hyperium/http#682 ``` error[E0599]: no method named `try_insert` found for mutable reference `&mut HeaderMap` in the current scope --> tonic/src/transport/channel/service/user_agent.rs:44:14 | 42 | if let Ok(Some(user_agent)) = req | _______________________________________- 43 | | .headers_mut() 44 | | .try_insert(USER_AGENT, self.user_agent.clone()) | |_____________-^^^^^^^^^^ | help: there is a method `insert` with a similar name | 44 - .try_insert(USER_AGENT, self.user_agent.clone()) 44 + .insert(USER_AGENT, self.user_agent.clone()) | ``` Co-authored-by: tottoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #617. Merge conflicts were resolved, and a case of a breaking change was resolved since I forgot
try_entry()needed to change return types before we release 1.0. Sigh.