Skip to content

migration: follow telemetry.distro semantic convention (logs) #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2025
Merged

migration: follow telemetry.distro semantic convention (logs) #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dfa6fa
migration: follow telemetry.distro semantic convention (logs)
wrn14897 Oct 10, 2025
4cabf33
docs: add a changeset
wrn14897 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wise-cows-hunt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@hyperdx/node-opentelemetry': minor
---

migration: follow telemetry.distro semantic convention (logs)
4 changes: 2 additions & 2 deletions packages/node-opentelemetry/src/otel-logger/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ export class Logger {
this.provider = new LoggerProvider({
resource: detectedResource.merge(
new Resource({
// TODO: should use otel semantic conventions
'hyperdx.distro.version': PKG_VERSION,
'telemetry.distro.name': 'hyperdx',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be hyperdx-js. will leave it for later

'telemetry.distro.version': PKG_VERSION,
[SEMRESATTRS_SERVICE_NAME]: service ?? _serviceName,
...resourceAttributes,
}),
Expand Down