More robust MTR target detection, fix duplicate rm#61
Open
menakite wants to merge 1 commit intohybula:mainfrom
Open
More robust MTR target detection, fix duplicate rm#61menakite wants to merge 1 commit intohybula:mainfrom
menakite wants to merge 1 commit intohybula:mainfrom
Conversation
* Do not always overwrite targetIndex; * duplicate removal was off by one. Cosmetic: show a final "waiting for reply" hop if target doesn't reply to ICMPs.
menakite
force-pushed
the
mtr-more-fixes
branch
from
46f863d to
d671cac
Compare
Contributor
|
@menakite any news about this? 😄 |
Contributor
Author
Hi, I can say this PR doesn't break anything, but I wasn't able to reproduce the reported issue, hence I'm not sure if this could definitely fix it or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
targetIndex;I'm still trying to completely fix the reported issue.
Cosmetic: show a final "waiting for reply" hop if target doesn't reply to ICMPs, or didn't yet.