Open
Conversation
Member
Author
|
Tested with 0.4.2 (which doesn't have the conf file, so defaults are set correctly) and latest (which does, and uses that instead) and all works well. 👍 |
| ] | ||
|
|
||
| // Only include the VIP WPCS if the path exists within this version of the standards. | ||
| if ( fs.existsSync( path.join( standardPath, 'vendor', 'automattic', 'vipwpcs' ) ) ) { |
Contributor
There was a problem hiding this comment.
Seems like we can just add this to the above list if we're using DealerDirect, ya?
I managed to totally misread this 😬ignore me.
Contributor
There was a problem hiding this comment.
Do we even need this if we're far back enough to not have had DealerDirect?
Member
Author
There was a problem hiding this comment.
I think so? I think we had overlap.
mikeselander
reviewed
Apr 9, 2020
| ] | ||
|
|
||
| // Only include the VIP WPCS if the path exists within this version of the standards. | ||
| if ( fs.existsSync( path.join( standardPath, 'vendor', 'automattic', 'vipwpcs' ) ) ) { |
Contributor
There was a problem hiding this comment.
Do we even need this if we're far back enough to not have had DealerDirect?
Member
Author
|
Ah nope, this still needs updating. My bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obsoletes #108. Fixes #97.
This checks for the presence of phpcs' internal configuration file (i.e. the one use for
--config-set/etc) atvendor/squizlabs/php_codesniffer/CodeSniffer.conf. Whendealerdirect/phpcodesniffer-composer-installeris required, it runsphpcs --config-set installed_paths ...after any package is added or removed. This creates the config file.Installed paths are now only set manually if there's no configuration, allowing us to bundle this properly into the standard instead.