Document module-ci-v1 moving-tag convention#1089
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mikelittle
requested review from
ferschubert-hm,
filter182,
jerico,
vladislavhmn and
wisyhambolu
July 2, 2026 16:34
wisyhambolu
requested changes
Jul 15, 2026
Comment on lines
+53
to
+56
| The bulk helper at `humanmade/altis/scripts/update-module-gha-ref.sh` opens a PR per module repo to (re)point the `uses:` ref — used for the one-time move of a branch onto a tag, or to pin a specific SHA. It takes a ref (a tag/branch name kept literal, or a hex SHA pinned) and a `BASE_BRANCH` (default `master`): | ||
|
|
||
| ```sh | ||
| BASE_BRANCH=v25-branch update-module-gha-ref.sh module-ci-v1 "<why>" |
Contributor
There was a problem hiding this comment.
You mention BASE_BRANCH but it is never used within the script https://github.com/humanmade/product-dev/blob/master/scripts/update-module-gha-ref.sh, i think this should rather be ./update-module-gha-ref.sh module-ci-v1 --base v25-branch.
Also <why> seems to missing an argument as it would land on * and return unknown argument: <why>. I think it should be ./update-module-gha-ref.sh module-ci-v1 --base v25-branch --message "<why>".
The right doc is actually used in https://github.com/humanmade/product-dev/pull/2192/changes so I'm guessing this was an oversight.
Contributor
Author
There was a problem hiding this comment.
The script has changed since this PR. I'll merge the updates and check it tthrough again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents that module branches track the
module-ci-v1moving tag — how to move it for compatible changes, and when to cutmodule-ci-v2for breaking ones — in the workflows README.