Skip to content

Conversation

nico-martin
Copy link
Collaborator

@nico-martin nico-martin commented Oct 10, 2025

The following errors from #1409 are adressed by this PR:

  • Added a type definition (@typedef) that tells TypeScript what PretrainedProcessorOptions is
  • Changed the parameter type from "an array of Tensors" to "exactly 3 Tensors" (char, bpe, wp)
  • The sharp import error (needs esModuleInterop)

Closes #1337
Closes #1409

@nico-martin nico-martin requested a review from xenova October 10, 2025 17:09
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@xenova xenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks ✅

just a minor nit + comments

@xenova xenova changed the title This is a fix for the ts-errors from Issue 1409 Type error fixes Oct 10, 2025
@xenova xenova merged commit fcf2ec9 into huggingface:main Oct 14, 2025
4 checks passed
nico-martin added a commit to nico-martin/transformers.js that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting TS2304: Cannot find name 'PretrainedProcessorOptions'. error 3.5.2 typescript build errors

3 participants