FIX get_layer_device_map StopIteration on CPU-only device maps - #3621
Open
Cunninger wants to merge 1 commit into
Open
FIX get_layer_device_map StopIteration on CPU-only device maps#3621Cunninger wants to merge 1 commit into
Cunninger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3619
get_layer_device_map()assumed everyhf_device_mapcontains at least one device that is not"cpu"or"disk":A valid CPU-only map such as
{"": "cpu"}(typical for CPU-only prefix-tuning) raisesStopIterationbefore the existing single-root handler can run.This keeps the GPU/accelerator path unchanged, and falls back to the first non-disk device (default
"cpu") when the map is CPU/disk-only.Tests
6 related tests in that class: 3 passed locally (CPU-only single-root map, per-layer GPU map, CPU offload mixed with GPU).
AI assistance
AI assistance was used to draft this change. I reviewed every line, reproduced the
StopIterationfrom #3619, and ran the tests above. Coordination comment: #3619 (comment)