Skip to content

flash-attn2: avoid incorrect out allocation - #913

Merged
drbh merged 1 commit into
mainfrom
adjust-flash-attn-wrapper
Jun 3, 2026
Merged

flash-attn2: avoid incorrect out allocation#913
drbh merged 1 commit into
mainfrom
adjust-flash-attn-wrapper

Conversation

@drbh

@drbh drbh commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

This PR removes an unneeded allocation of the out tensor which causes shape errors in some cases

@drbh

drbh commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot build-and-stage flash-attn2

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build-and-stage flash-attn2
Mode: build and stage
Target branch: pr-913
PR head SHA: d3fafb05d468975e3a599a6300f3c9671d4628b4
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@drbh

drbh commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot build-and-merge

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Invalid command. Use /kernel-bot <build|build-and-stage|merge-and-upload|release> <kernel1> [kernel2 ...] [--branch <target_branch>].

@drbh

drbh commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot build-and-merge flash-attn2

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Invalid command. Use /kernel-bot <build|build-and-stage|merge-and-upload|release> <kernel1> [kernel2 ...] [--branch <target_branch>].

@drbh

drbh commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot merge-and-upload flash-attn2

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Build request failed.

Command: /kernel-bot merge-and-upload flash-attn2
Mode: merge, build and upload
Target branch: main
PR head SHA: d3fafb05d468975e3a599a6300f3c9671d4628b4
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Failure: Failed to merge PR before build/upload. Check mergeability and required checks.

@drbh drbh changed the title fix: avoid incorrect out allocation flash-attn2: avoid incorrect out allocation Jun 3, 2026
@drbh
drbh merged commit a511a4c into main Jun 3, 2026
6 checks passed
@drbh

drbh commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot release flash-attn2

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot release flash-attn2
Mode: release (linux + mac + windows)
Target branch: ``
PR head SHA: d3fafb05d468975e3a599a6300f3c9671d4628b4
Workflows: `build.yaml, build-mac.yaml, build-windows.yaml`

Dispatched (1):

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot release flash-attn2
Mode: release (linux + mac + windows)
Target branch: ``
PR head SHA: d3fafb05d468975e3a599a6300f3c9671d4628b4
Workflows: `build.yaml, build-mac.yaml, build-windows.yaml`

Dispatched (1):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants