Skip to content

sync fa4 and add smoke tests. - #1147

Open
sayakpaul wants to merge 9 commits into
mainfrom
fa4-sync-smoke-tests
Open

sayakpaul wants to merge 9 commits into
mainfrom
fa4-sync-smoke-tests

Conversation

@sayakpaul

@sayakpaul sayakpaul commented Sep 11, 2026

Copy link
Copy Markdown
Member

Since it's a no-arch kernel, didn't bump the version (need to fix the checker; separate PR).

@github-actions github-actions Bot added the chore Version bumps, releases, misc maintenance label Sep 11, 2026
@sayakpaul

Copy link
Copy Markdown
Member Author

/kernel-bot build flash-attn4

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build flash-attn4
Mode: build only
Target branch: pr-1147
PR head SHA: 49e0aa8579102c79527086cb8edd7c1c90f8215d
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@sayakpaul

Copy link
Copy Markdown
Member Author

/kernel-bot build flash-attn4

@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build flash-attn4
Mode: build only
Target branch: pr-1147
PR head SHA: 2ad88394ddf674c7646787a3ecd881ae27e60e69
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@sayakpaul
sayakpaul marked this pull request as ready for review September 12, 2026 06:50
Comment thread flash-attn4/tests/cute/benchmark_block_sparsity.py Outdated
Comment thread flash-attn4/torch-ext/flash_attn4/interface.py
@sayakpaul

Copy link
Copy Markdown
Member Author

/kernel-bot build flash-attn4

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build flash-attn4
Mode: build only
Target branch: pr-1147
PR head SHA: f6e8b7db0e030480e9aa0c9cfa6283c581dd45b1
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@sayakpaul

sayakpaul commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

@danieldk addressed the feedback. The public check API needs a bit more work which I will do in a separate PR (followed by an update in the instructions to bump version for no-arch kernels).

@danieldk danieldk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two more small comments

Comment thread flash-attn4/torch-ext/flash_attn4/__init__.py Outdated
Comment thread flash-attn4/torch-ext/flash_attn4/benchmark_flash_attention_fp8.py Outdated
@sayakpaul

Copy link
Copy Markdown
Member Author

/kernel-bot build flash-attn4

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build flash-attn4
Mode: build only
Target branch: pr-1147
PR head SHA: 4a67a0d46d5d6cddaf473e206eb6e27ea967eee4
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@sayakpaul

Copy link
Copy Markdown
Member Author

/kernel-bot build flash-attn4

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build flash-attn4
Mode: build only
Target branch: pr-1147
PR head SHA: 20d5fc7a3dceb1a47d77b6995d0e9099e71af70e
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@sayakpaul

Copy link
Copy Markdown
Member Author

@danieldk I think I have resolved all your comments. Regarding running the tests on Hopper and Blackwell, I did that too. Some tests didn't run because of environment problems and I didn't chase them further (but note that these are just 10ish in number).

@sayakpaul
sayakpaul requested a review from danieldk September 17, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Version bumps, releases, misc maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants