Krea2 Modular Pipeline Support, Documentation, Test Cases#14083
Krea2 Modular Pipeline Support, Documentation, Test Cases#14083Cedric-Perauer wants to merge 20 commits into
Conversation
|
Hi @Cedric-Perauer, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The tiny-krea2-modular-pipe for test cases here still needs to be mirrored from https://huggingface.co/CedricPerauer/tiny-krea2-modular-pipe to hf-internal-testing. This is currently leading to the failing modular/fast pytorch check |
dg845
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left some comments :).
| latent_height = block_state.height // components.vae_scale_factor | ||
| latent_width = block_state.width // components.vae_scale_factor |
There was a problem hiding this comment.
Should we round block_state.height and block_state.width to a multiple of self.vae_scale_factor * self.patch_size before calculating latent_height and latent_width like the standard Krea2 pipeline does?
diffusers/src/diffusers/pipelines/krea2/pipeline_krea2.py
Lines 534 to 542 in 208704a
Co-authored-by: dg845 <58458699+dg845@users.noreply.github.com>
Co-authored-by: dg845 <58458699+dg845@users.noreply.github.com>
Co-authored-by: dg845 <58458699+dg845@users.noreply.github.com>
|
Hello :) I'm not sure if this is the right time to bring this up or if it would be better to address it in a follow-up PR: it would be great if Krea's modular pipeline could also handle reference images. I’m thinking of these new cool LoRAs: |
|
Thanks for the suggestions @dg845 I added the changes. |
What does this PR do?
This PR implements the Krea2 modular pipeline according to requested feature :
Fixes #14056
The
tiny-krea2-modular-pipefor test cases here still needs to be mirrored from https://huggingface.co/CedricPerauer/tiny-krea2-modular-pipe tohf-internal-testingValidation
Full PyTest output
Docs
Krea2.md is updated accordingly with small section for the modular pipeline
Before submitting
.ai/review-rules.md?documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Potential reviewers for pipelines/models: @yiyixuxu @dg845 @asomoza
cc @SamuelTallet