[tests] implement base model output caching in model-level tests#14059
Merged
Conversation
Member
Author
|
/diffusers-bot pytest tests/models/transformers/test_models_transformer_flux.py -k "offload" |
Contributor
|
✅ |
dg845
reviewed
Jun 25, 2026
| Tests that still need a live model (e.g. to save or offload it) build their own with the same | ||
| seed, so the reloaded model's weights match this cached output. | ||
| """ | ||
| torch.manual_seed(0) |
Collaborator
There was a problem hiding this comment.
Should BaseModelOutputMixin also expose the seed it uses to create the base_model_output fixture? I think this would allow tests to more easily match its behavior.
Member
Author
There was a problem hiding this comment.
I thought about it but then this change should also be propagated to the generator property, e.g.
So, I think this should be done in a separate PR.
dg845
approved these changes
Jun 25, 2026
dg845
left a comment
dg845
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! Left one comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements fixture-level caching of base model output to avoid recomputation:
common.pymemory.pyOther mixins don't have the right contract to implement it yet.